enrich adapter response for UPDATE and SELECT queries #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjh336
changed the title
|
HI, reviewed and passed it onto testing till @jtcohen6 has a chance to take a look, but noticed that your code is a little out of date and would love if it if you could update your branch with latest from main and make sure tests still pass. |
|
Hi just wanting to pass along that you may need to merge main again per #93 bigquery like postgres adapter have a test that was failing due to addition of a stricter type checking. should clear up the two python tests. |
|
Thanks @McKnight-42 - all up to date now :) |
McKnight-42
approved these changes
Jan 7, 2022
siephen
pushed a commit
to AgencyPMG/dbt-bigquery
that referenced
this pull request
May 16, 2022
* enirch adapter response for UPDATE and SELECT queries * code style change Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #68
Description
Add logic in
BigQueryConnectionManager.executeto enrich the response with more info for UPDATE and SELECT statements.UPDATE responses will match that of other DML operations, while SELECT will return the following:
bytes_processed= total reported bytes processed from running the SELECT statementrows_affected= number of rows in the query resultChecklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.