Simplify usage of BigQuery's TableReference and DatasetReference Classes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drewmcdonald seems some recent mergers are not working well with your current pr, if you could update main, hopefully that will clear them up if not I will do my best to help find the issues and get them fixed. |
merge main into feature branch.
|
@McKnight-42 looks like things are all good after updating! |
McKnight-42
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Great Work @drewmcdonald thanks so much for this contribution.
|
Thanks! Happy to jump in. |
McKnight-42
added a commit
that referenced
this pull request
Jan 26, 2022
…ses (#98) * drop conn method argument in _query_and_results. * update Table Ref and Dataset Ref usage. * update changelog. Co-authored-by: Matthew McKnight <[email protected]>
4 tasks
siephen
pushed a commit
to AgencyPMG/dbt-bigquery
that referenced
this pull request
May 16, 2022
…ses (dbt-labs#98) * drop conn method argument in _query_and_results. * update Table Ref and Dataset Ref usage. * update changelog. Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #97
Description
Addresses a deprecation warning (see #97) and moves closer to BQ API best practices by preferring unconnected
*Referenceobjects until connected client operations are needed.BigQueryConnectionManager.datasetto directly create abigquery.DatasetReference, and renames that method todataset_reffor clarity.BigQueryConnectionManager.table_refto directly create abigquery.TableReferenceChecklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.