-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] event time config #9490
Comments
I keep a collection of terminology here. I should add those bi-temporal definitions for "event time" and "processing time" from Spark: The Definitive Guide ! I have a hard time sorting out the differences between all these temporal dimensions and their implications, so that's why I created that repo. It's still hard for me to reason about 😅. No matter which terminology we land on ("event_time", etc), we'll want to do a good job of explaining what it means and how it fits in. |
dummy example of what a future incremental model could look like where we automatically generate the
|
The dummy example of {
"field": "<field name>",
"data_type": "<timestamp | date | datetime | int64>",
"granularity": "<hour | day | month | year>"
# Only required if data_type is "int64"
"range": {
"start": <int>,
"end": <int>,
"interval": <int>
}
} The Within the config, {{ config(
materialized='table',
partition_by={
"field": "created_at",
"data_type": "timestamp",
"granularity": "day"
}
)}} |
@jtcohen6 and I discussed and believe Option 1 is the best path forward here. Acceptance Criteria
|
Is this your first time submitting a feature request?
Describe the feature
There are many use cases where it would be helpful to know the event time field of a given model:
This is similar to a handful of our current configs:
We believe this is distinct from your partition key, because it's likely you want to filter on something different (event_time) than what you’re partitioning on (processing_time) - event time vs processing time.
We should add a new config to allow folks to specify the event time field for a given model.
Notion doc
Acceptance Criteria
event_time
that accepts SQL (name of a column, or SQL liketo_date(my_time_col)
; similar toloaded_at_field
)dbt_project.yml
or in schema ymlYML design options
Option 1: field name field
loaded_at_field
Option 2: dictionary config
Open considerations
event_time
,event_time_field
, something else?Additional context here
Additional requirement
Add some document about how config on node and config in node.config works(code level implementation) while working on the ticket.
related issue #7157
https://docs.getdbt.com/reference/configs-and-properties
The text was updated successfully, but these errors were encountered: