Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin versions so CI and local dev match #10358

Merged
merged 1 commit into from
Jun 24, 2024
Merged

pin versions so CI and local dev match #10358

merged 1 commit into from
Jun 24, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jun 24, 2024

resolves #

Problem

Requirements for pre-commit hooks were unpinned in dev-requirements.txt resulting in differences for local development and CI.

Solution

Pin the requirements in dev-requirements so that local development matches CI.

Bump isort because there was no breaking change.

black breaks and requires other code changes for major version 24 so I left the pin as is for now
flake8 also finds more problems on 1.10 so left that as well

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jun 24, 2024
@emmyoop emmyoop requested a review from a team as a code owner June 24, 2024 16:13
@cla-bot cla-bot bot added the cla:yes label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (2bae05b) to head (afe0430).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10358      +/-   ##
==========================================
- Coverage   88.81%   88.75%   -0.06%     
==========================================
  Files         180      180              
  Lines       22486    22486              
==========================================
- Hits        19970    19957      -13     
- Misses       2516     2529      +13     
Flag Coverage Δ
integration 86.01% <ø> (-0.14%) ⬇️
unit 62.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.19% <ø> (ø)
Integration Tests 86.01% <ø> (-0.14%) ⬇️

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 64c5947 into main Jun 24, 2024
77 of 78 checks passed
@emmyoop emmyoop deleted the er/pin-black branch June 24, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants