Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Microbatch parallelism #10958

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

[WIP] Microbatch parallelism #10958

wants to merge 17 commits into from

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Oct 31, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

TODO:

  • consider adapter opt-in
  • model-level configuration for parallel vs serial execution mode
  • get dbt build working with MicrobatchModelRunner
  • keyboard interrupts
  • look into auto-detecting 'this' usage

Refactors:

  • make batch_callback simpler + thread safe
  • unify serial + parallel while loops
  • override init on MicrobatchModelRunner to accept batch_idx, batches, and relation_exists
  • refactor 'handler' to 'handle_microbatch_runner' on RunTask

@cla-bot cla-bot bot added the cla:yes label Oct 31, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.41%. Comparing base (35c0920) to head (62f93ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10958      +/-   ##
==========================================
- Coverage   89.06%   86.41%   -2.65%     
==========================================
  Files         183      183              
  Lines       23634    23704      +70     
==========================================
- Hits        21049    20484     -565     
- Misses       2585     3220     +635     
Flag Coverage Δ
integration 86.41% <94.73%> (+0.03%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.41% <94.73%> (-2.65%) ⬇️
Integration Tests 86.41% <94.73%> (+0.03%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant