Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose proxy_user and proxy_password from SnowflakeConnection to SnowflakeCredentials class #1303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brifitz
Copy link

@brifitz brifitz commented Jan 29, 2025

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Unable to connect to Snowflake in a corporate environment as proxy_user and proxy password are not attributes of SnowflakeCredentials. These attributes are attributes of the underlying SnowflakeConnection, just like proxy_host and proxy_port, however the SnowflakeCredentials class does not currently expose them.

Solution

Successfully connected to Snowflake after hard-coding the proxy_user and proxy password in the snowflake.connector.connect(...) in the SnowflakeConnectionManager class.

This PR exposes the proxy_user and proxy password attributes of the underlying SnowflakeConnection class to the SnowflakeCredentials class so that the above workaround is not needed.

Checklist

  • [ x] I have read the contributing guide and understand what's expected of me
  • [ x] I have run this code in development and it appears to resolve the stated issue
  • [ x] This PR includes tests, or tests are not required/relevant for this PR
  • [ x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@brifitz brifitz requested a review from a team as a code owner January 29, 2025 19:53
@cla-bot cla-bot bot added the cla:yes label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant