Fail integration tests appropriately #545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #540
This is a:
Description & motivation
The integration tests passed in CircleCI even though one of the dbt steps failed. This is because the shell script only returns the final exit code -- intermediate exit codes are ignored by default.
Several options to solve this issue are discussed here.
Chosen option:
command || exit 1
because it is minimally invasive, low risk, and preserves our optionality in the future.Positive Consequences
|| exit 1
suffix to 5 lines of codeNegative Consequences
run_test.sh
scriptChecklist
star()
source)limit_zero()
macro in place of the literal string:limit 0
dbt_utils.type_*
macros instead of explicit datatypes (e.g.dbt_utils.type_timestamp()
instead ofTIMESTAMP