remove list_relations call in materialization #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Oct 17, 2018
| @@ -0,0 +1,16 @@ | |||
| {{ | |||
There was a problem hiding this comment.
Can we do something hacky to get these tests to pass? Let's just not configure this model for Postgres, making it use the view materialization instead
Suggested change
| {{ | |
| {% if target.type != 'postgres' %} | |
| {{ | |
| ... | |
| }} | |
| {% endif %} |
There was a problem hiding this comment.
^ I guess this fails during parsing? Boo. Might be worth just implementing that if/else block
There was a problem hiding this comment.
It turns out that the circlei script doesn't run the makefile, I just made the circle config match.
drewbanin
reviewed
Oct 17, 2018
| dbt run --target postgres | ||
| dbt test --target postgres | ||
| dbt run --target postgres --exclude test_insert_by_period | ||
| dbt test --target postgres --exclude test_insert_by_period |
There was a problem hiding this comment.
that is a lot smarter than what i said
beckjake
force-pushed
the
remove-list-relations
branch
2 times, most recently
from
2be3f34 to
a58e1ca
Compare
beckjake
force-pushed
the
remove-list-relations
branch
from
a58e1ca to
de24e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caching PR I wrote removes
list_relationsfrom the DBWrapper, so remove the explicit call from the materialization.This change is backwards compatible: Currently in the absence of a
relations_list, the adapter code callslist_relationson its own.