Babbage utilities #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
commented
Jul 15, 2022
|
|
||
| utxos: Vec<InputBuilderResult>, | ||
| collateral_return: Option<TransactionOutput>, | ||
| total_collateral: Option<Coin>, |
There was a problem hiding this comment.
Note: currently no good way to set this. Will have to be done in a follow-up PR
SebastienGllmt
commented
Jul 15, 2022
| @@ -3698,6 +3698,63 @@ impl Deserialize for NetworkId { | |||
| } | |||
| } | |||
|
|
|||
| impl cbor_event::se::Serialize for Datum { | |||
There was a problem hiding this comment.
@rooooooooob I'm not sure what was up with this TxOutputData type. The datum_option type is part of the binary spec so I just replaced it with this and manually added the (de)serialization for it
rooooooooob
added a commit
that referenced
this pull request
Aug 4, 2022
During #81 `utils.rs` was refactored into many places and some wouldn't be using `error::JsError` which in wasm builds is a typedef for `js_sys::JsValue` and is its own struct for rust builds (to avoid panics in JsValue when used from non-wasm builds). Howeve, some places couldn't see these types and would pull it in directly from `wasm_bindgen::prelude` from the wildcare import in `lib.rs`. This caused an issue when bumping `wasm_bindgen` as the `from_str()` method is no longer in `js_sys::JsError` but still is in `JsValue`. Between now and #81 this would have also led to panics if many places when an error was returned when using CML from rust instead of wasm. In the future we should deprecate the direct usage of `js_sys::JsValue` and remove our `JsError` type on rust in favor for real rust errors (not just string wrappers). See rustwasm/wasm-bindgen#2710 >Expands the acceptable return-position types to Result<T, E> where T: IntoWasmAbi, E: Into<JsValue>, so you can easily throw your own custom error classes imported from JS which will greatly improve error handling from the rust side but this should be done after the rust/wasm split.
This was referenced Aug 4, 2022
SebastienGllmt
pushed a commit
that referenced
this pull request
Aug 10, 2022
During #81 `utils.rs` was refactored into many places and some wouldn't be using `error::JsError` which in wasm builds is a typedef for `js_sys::JsValue` and is its own struct for rust builds (to avoid panics in JsValue when used from non-wasm builds). Howeve, some places couldn't see these types and would pull it in directly from `wasm_bindgen::prelude` from the wildcare import in `lib.rs`. This caused an issue when bumping `wasm_bindgen` as the `from_str()` method is no longer in `js_sys::JsError` but still is in `JsValue`. Between now and #81 this would have also led to panics if many places when an error was returned when using CML from rust instead of wasm. In the future we should deprecate the direct usage of `js_sys::JsValue` and remove our `JsError` type on rust in favor for real rust errors (not just string wrappers). See rustwasm/wasm-bindgen#2710 >Expands the acceptable return-position types to Result<T, E> where T: IntoWasmAbi, E: Into<JsValue>, so you can easily throw your own custom error classes imported from JS which will greatly improve error handling from the rust side but this should be done after the rust/wasm split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a bunch of Babbage utility functions