Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getHeaders() decode broke information #171

Closed
BenjaminHoegh opened this issue Sep 22, 2017 · 3 comments
Closed

getHeaders() decode broke information #171

BenjaminHoegh opened this issue Sep 22, 2017 · 3 comments
Labels
Milestone

Comments

@BenjaminHoegh
Copy link

BenjaminHoegh commented Sep 22, 2017

in the code (Headers.php):

61    case 'cc':
62    $emails = [];
63    foreach ($value as $address) {
64        $emails[] = $this->decodeEmailAddress($address);
65    }
66            
67    return $emails;
68    case 'subject':
69         return $this->decode($value);
70    default:
71         return $value;

$this->decode($value) at line 69 broke the subject and return a empty string

@Slamdunk Slamdunk added the bug label Sep 22, 2017
@Slamdunk
Copy link
Collaborator

The decode function is under investigation, but we need test cases to add to our test suite: can you provide the raw message headers of the email that caused your error?

@BenjaminHoegh
Copy link
Author

Okay so today I just change my own code and now it don't become mad over the decode(). Why I don't know, nothing make sens, but the important is that it works

Slamdunk added a commit that referenced this issue Sep 27, 2017
Message charset: mb_convert_encoding + aliases
Closes #78 #85 #115 #132 #136 #158 #165 #171 #174 #176
@Slamdunk Slamdunk added this to the 1.0 milestone Sep 27, 2017
@Slamdunk
Copy link
Collaborator

Thank you for your feedback, the issue has been fixed in #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants