-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: use local Dovecot installation #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There are still four failing test cases, of which two have to do with encoding issues. Do you have any idea why Ddeboer\Imap\Tests\MessageTest::testKeepUnseen
and Ddeboer\Imap\Tests\MessageTest::testDelete
no longer work?
Yes, I did it on purpose: first fix the test environment, and only then fix the tests
Encoding is a nightmare; we'll need a lot of test cases and dedicated tests. I'll work on them only after everything else because they deserve special attention
|
@ddeboer I consider this PR complete, but I see you requested some changes through the review, without specific changes pinpointed. Are there any more changes needed, or can we merge it? After this one, a lot PR will follow:
|
I was referring to the failing test cases. Do you want to fix them in separate PRs? |
Yes, I already am, because other users can better track what happened and why:
|
composer.lock
: catch forward compatibility breaks earlyTests: fix failuresto ease this PR, new PR will come to fix the tests