Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain imap_getmailboxes() results #184

Merged
merged 3 commits into from
Sep 26, 2017

Conversation

Slamdunk
Copy link
Collaborator

@Slamdunk Slamdunk commented Sep 26, 2017

  • Keep both mailbox server encoded name and decoded path resulted by imap_getmailboxes
  • Keep imap_getmailboxes infos both in Connection and in Mailbox (closes Error when trying fetch messages from container #167)
  • Encode mailbox name only where it's needed: during mailbox creation
  • Decode mailbox name only where it's needed: during imap_getmailboxes
  • Restrict code-coverage with @covers annotation
  • Get 100% code-coverage on Connection and Mailbox

BC Breaks

Signature of Ddeboer\Imap\Mailbox changed.

@Slamdunk Slamdunk changed the title [WIP] Retain imap_getmailboxes results Retain imap_getmailboxes results Sep 26, 2017
@Slamdunk Slamdunk merged commit c5bed1e into ddeboer:develop Sep 26, 2017
@Slamdunk Slamdunk deleted the mailbox_refactor branch September 26, 2017 12:14
@Slamdunk Slamdunk changed the title Retain imap_getmailboxes results Retain imap_getmailboxes() results Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant