Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading Mailbox::expunge() #206

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

Slamdunk
Copy link
Collaborator

Consider this code:

$mailboxOne = $connection->getMailbox('one');
$mailboxTwo = $connection->getMailbox('two');

$mailboxOne->getMessages()[0]->delete();
$mailboxTwo->getMessages()[0]->delete();

$mailboxOne->expunge();

A user can think that only the message of the first mailbox is deleted, while in reality both are deleted.

@Slamdunk Slamdunk added this to the 1.0 milestone Sep 29, 2017
@Slamdunk Slamdunk merged commit fadb08f into ddeboer:develop Sep 29, 2017
@Slamdunk Slamdunk deleted the connection_expunge branch September 29, 2017 12:47
@Slamdunk Slamdunk mentioned this pull request Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant