Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded messages: refactor #106 #216

Merged
merged 10 commits into from
Oct 2, 2017
Merged

Embedded messages: refactor #106 #216

merged 10 commits into from
Oct 2, 2017

Conversation

Slamdunk
Copy link
Collaborator

@Slamdunk Slamdunk commented Oct 2, 2017

Refactor of #106 with following differencies:

  1. Message is a sublcass of Message\AbstractMessage
  2. Message\EmbeddedMessage is a sublcass of Message\AbstractMessage (No dedicated EmbeddedMessage\EmbeddedMessage class)
  3. Message\Attachment is the only attachment type (No dedicated EmbeddedMessage\EmbeddedAttachment class)
  4. No dedicated EmbeddedMessage\EmbeddedPart class
  5. Recursive embedded email allowed

@Slamdunk Slamdunk added this to the 1.0 milestone Oct 2, 2017
@Slamdunk Slamdunk changed the title Embedded messages Embedded messages: refactor #106 Oct 2, 2017
@Slamdunk Slamdunk merged commit 912573b into ddeboer:develop Oct 2, 2017
@Slamdunk Slamdunk deleted the embedded_messages branch October 2, 2017 14:26
@Slamdunk Slamdunk mentioned this pull request Oct 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Slamdunk