New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mocking ability through Interfaces #221

Merged

Slamdunk merged 2 commits into ddeboer:develop from Slamdunk:interfaces

Oct 3, 2017

Collaborator

Slamdunk commented Oct 3, 2017 •

edited

Loading

BC breaks

Parts now extend Ddeboer\Imap\Message\AbstractPart
Part that aren't embedded messages nor attachments are now Ddeboer\Imap\Message\SimplePart
Ddeboer\Imap{ => \Message}\Parameters

This helps typehinting segregation, and now all non-abstract classes are final


          Add interfaces to non-valueobjects classes

9de2ff5

Slamdunk added BC break enhancement labels

Slamdunk added this to the 1.0 milestone

Slamdunk force-pushed the interfaces branch from 8c862d0 to 38cd38a Compare

October 3, 2017 10:55


          Mark methods of abstract classes final where possible

9e608d4

Slamdunk force-pushed the interfaces branch from 38cd38a to 9e608d4 Compare

October 3, 2017 11:57

Slamdunk merged commit 54006b7 into ddeboer:develop

Slamdunk deleted the interfaces branch

October 3, 2017 12:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC break enhancement