Fixed error #23 and error with unknown message structure #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you elaborate on what this PR accomplishes? |
|
Some mails do not provide a vaild message structure type, see https://github.com/thelfensdrfer/imap/commit/ea783c58de50de5f6436033d6b68aa3f312c8db0 When i was creating the pull request, I scanned my hole email account to insert the mail into a database. Without this fix, some emails could not be parsed and the script terminated at this point. |
ddeboer
added a commit
that referenced
this pull request
Jan 24, 2015
| $this->headers = new Message\Headers($headers); | ||
| try { | ||
| $headers = \imap_header($this->stream, $this->messageNumber); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
I’m not sure imap_header ever throws exceptions. It would be more in the line of PHP to emit some silly warning or notice.
There was a problem hiding this comment.
I am no fan of try/catch but when I added it there was assuredly at least one exception...I think;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.