-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved error handling for message search method #445
Conversation
Hi, So, my goal is to catch this kind of errors and prevent them from producing incorrect results. Now, I understand that such errors might not be relevant to InvalidSearchCriteriaException and we might need to introduce new exception type which will be responsible for errors caused "in between" search operation. What do you think? |
Ok, if so please use |
Do you think we need a new exception type for this to separate it from search criteria specific cases? |
It is a good idea, but not for now it's good as is |
Thank you! |
This reverts commit 208a29f.
closes #444
I wasn't able to reproduce(through tests) the issue reported in #444 as it's server specific and not trivial. However, this change doesn't break existing tests for search functionality.