Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailbox::addMessage: consume $internalDate even when $options is null #499

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

arnolem
Copy link
Contributor

@arnolem arnolem commented Apr 21, 2021

Add PHP 7.4 support (It's ok @Slamdunk ?).

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #499 (ac4fde5) into master (085aae9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #499      +/-   ##
============================================
- Coverage     95.64%   95.63%   -0.01%     
+ Complexity      356      355       -1     
============================================
  Files            45       45              
  Lines           849      848       -1     
============================================
- Hits            812      811       -1     
  Misses           37       37              
Impacted Files Coverage Δ Complexity Δ
src/Mailbox.php 97.91% <100.00%> (-0.03%) 37.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085aae9...ac4fde5. Read the comment docs.

@Slamdunk Slamdunk changed the title Fix addmessage Mailbox::addMessage: consume $internalDate even when $options is null Apr 27, 2021
@Slamdunk Slamdunk merged commit 0e7d338 into ddeboer:master Apr 27, 2021
@Slamdunk
Copy link
Collaborator

Thank you @arnolem

saintsloth pushed a commit to saintsloth/imap that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants