Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Countable Interface to MessageIteratorInterface. #514

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

lahx
Copy link
Contributor

@lahx lahx commented Jul 19, 2021

Since all classes which implement this interface inherit from \ArrayIterator the needed implementation is already done. This change allows count(MailboxInterface::getMessages).

…s which implement this interface inherit from \ArrayIterator the needed implementation is already done. This change allows count(MailboxInterface::getMessages).
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #514 (028aefa) into master (92c169b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage     95.63%   95.63%           
  Complexity      355      355           
=========================================
  Files            45       45           
  Lines           848      848           
=========================================
  Hits            811      811           
  Misses           37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c169b...028aefa. Read the comment docs.

@Slamdunk
Copy link
Collaborator

Thank you

@Slamdunk Slamdunk merged commit 857edb2 into ddeboer:master Jul 19, 2021
@lahx lahx deleted the fix-countable branch July 19, 2021 10:31
@lahx
Copy link
Contributor Author

lahx commented Jul 19, 2021

you're welcome

saintsloth pushed a commit to saintsloth/imap that referenced this pull request Oct 27, 2022
…l classes which implement this interface inherit from \ArrayIterator the needed implementation is already done. This change allows count(MailboxInterface::getMessages). (ddeboer#514)"

This reverts commit 857edb2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants