Initialize address as null. Previously if an email with no recipient … #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is loaded, the hostname is empty and the address property is not initialized. Prior to this change, when then trying to access the address via getAddress a 'Typed property must not be accessed before initialization' would be thrown
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=========================================
Coverage 95.63% 95.64%
Complexity 355 355
=========================================
Files 45 45
Lines 848 849 +1
=========================================
+ Hits 811 812 +1
Misses 37 37
Continue to review full report at Codecov.
|
|
Thank you |
saintsloth
pushed a commit
to saintsloth/imap
that referenced
this pull request
Oct 27, 2022
This reverts commit 45eb491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if an email with undisclosed recipients is received, calling getAddress will throw an Error 'Typed property Ddeboer\Imap\Message\EmailAddress::$address must not be accessed before initialization' as initialization of the address property only occurs when a non-null hostname is passed in.
(Some more info on this error
https://madewithlove.com/blog/software-engineering/typed-property-must-not-be-accessed-before-initialization/ )
Change is to initialize address as null before the hostname check. Thanks