Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP 8.0.1 for imap_msgno() bugfix #518

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

ddeboer
Copy link
Owner

@ddeboer ddeboer commented Sep 22, 2021

Fix #485.

This was caused by PHP bug #80438, which was fixed in 8.0.1.

@ddeboer ddeboer requested a review from Slamdunk September 22, 2021 14:54
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #518 (7c509f8) into master (45eb491) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #518   +/-   ##
=========================================
  Coverage     95.64%   95.64%           
  Complexity      355      355           
=========================================
  Files            45       45           
  Lines           849      849           
=========================================
  Hits            812      812           
  Misses           37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45eb491...7c509f8. Read the comment docs.

@ddeboer ddeboer mentioned this pull request Sep 22, 2021
@matthiasnoback
Copy link

Very nice, and thanks again for this nice library!

Copy link
Collaborator

@Slamdunk Slamdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is ok, but I'd like to remember that this will not prevent anyone to install ddeboer/imap:1.12.1 and run into #485 again.

Of course the user will eventually see the usage of an outdated version and question why, but still I feel @matthiasnoback's "hours of debugging time" will hit again many other users.

@Slamdunk Slamdunk merged commit 1672b70 into master Sep 23, 2021
@Slamdunk Slamdunk deleted the require-php-msgno-bugfix branch September 23, 2021 05:31
@ddeboer
Copy link
Owner Author

ddeboer commented Sep 23, 2021

That’s a good point @Slamdunk. Except for retagging previous versions (bad practice), or perhaps adding a section to the readme (which developers may or may not read), I don’t see a way to completely prevent that. Do you have any ideas?

@Slamdunk
Copy link
Collaborator

Already happened in other repos, no way to do it well, but no need to bother IMHO, composer notifies you are on an outdated minor, and we require to specify PHP version in order to open an issue, so we can address eventual new related issues quickly.

saintsloth pushed a commit to saintsloth/imap that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when get Message
3 participants