-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require PHP 8.0.1 for imap_msgno() bugfix #518
Conversation
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=========================================
Coverage 95.64% 95.64%
Complexity 355 355
=========================================
Files 45 45
Lines 849 849
=========================================
Hits 812 812
Misses 37 37 Continue to review full report at Codecov.
|
Very nice, and thanks again for this nice library! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is ok, but I'd like to remember that this will not prevent anyone to install ddeboer/imap:1.12.1
and run into #485 again.
Of course the user will eventually see the usage of an outdated version and question why, but still I feel @matthiasnoback's "hours of debugging time" will hit again many other users.
That’s a good point @Slamdunk. Except for retagging previous versions (bad practice), or perhaps adding a section to the readme (which developers may or may not read), I don’t see a way to completely prevent that. Do you have any ideas? |
Already happened in other repos, no way to do it well, but no need to bother IMHO, composer notifies you are on an outdated minor, and we require to specify PHP version in order to open an issue, so we can address eventual new related issues quickly. |
This reverts commit 1672b70.
Fix #485.
This was caused by PHP bug #80438, which was fixed in 8.0.1.