Mailbox: add renaming capability #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
============================================
+ Coverage 95.52% 95.57% +0.05%
- Complexity 354 356 +2
============================================
Files 45 45
Lines 826 837 +11
============================================
+ Hits 789 800 +11
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Slamdunk
requested changes
Aug 3, 2022
|
I've just pushed to |
OmarMonterrey
force-pushed
the
feature-rename-inbox
branch
from
84518eb to
b849e92
Compare
Co-authored-by: Filippo Tessarotto <[email protected]>
OmarMonterrey
force-pushed
the
feature-rename-inbox
branch
from
7a9df30 to
4b50167
Compare
|
Hi, can you also add tests please? |
|
Sorry I didn't took into account the encoding of the names, I fixed it for the tests to properly pass. |
Slamdunk
requested changes
Aug 5, 2022
Slamdunk
changed the title
|
Thank you @OmarMonterrey |
saintsloth
pushed a commit
to saintsloth/imap
that referenced
this pull request
Oct 27, 2022
This reverts commit c2e4d72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to open-source colaborating, so I'm sorry if I did something wrong.
This pull request is related to Issue #446 (Mailbox renaming feature request)