Method to get all html parts and complete html body #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.76% // Head: 94.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
============================================
+ Coverage 94.76% 94.86% +0.10%
- Complexity 356 368 +12
============================================
Files 45 45
Lines 898 935 +37
============================================
+ Hits 851 887 +36
- Misses 47 48 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Don't care about the |
Slamdunk
requested changes
Feb 16, 2023
Slamdunk
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create an email in Apple Mail and drag an PDF file in the middle of my email (so with text around) and send it, the getBodyHtml only returns the first part of the e-mail.
I added two methods
$message->getBodyHtmlParts()and$message->getCompleteBodyHtml(). I don't know if there is a better implementation without DOMDocument.I'd love to hear if improvements are possible. I think its better to rename the
$message->getBodyHtml()to for example$message->getFirstBodyHtml()but I don't want to break to much.Fixes for: #452 #454