fixes, refactoring #564
Merged
fixes, refactoring #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `imap_msgno()` method is strictly typehinted to return `int`, so the `is_numeric()` check makes no sense.
The specified type is already inferred from the source code.
`$msgno` was immediately overwritten 5 lines later.
Since we dropped support for PHP 8.0 and lower, this cast can be safely removed.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
============================================
+ Coverage 90.89% 95.10% +4.20%
+ Complexity 368 364 -4
============================================
Files 45 45
Lines 945 939 -6
============================================
+ Hits 859 893 +34
+ Misses 86 46 -40
☔ View full report in Codecov by Sentry. |
|
Thank you 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various fixes, addresses performance issues and does a little bit of refactoring here and there.
Read the commit messages for more information.
Overall functionality stayed the same.