Update README.md #26
Merged
Update README.md #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a header, update the test commands, add links, add example on successful test.
|
Thinking more about this, it would be great with a list of a few contrib modules which are known to pass all tests, showcasing both PHPUnit, as well as NightWatch. |
|
I created #27, the failing Simplenews and Admin Toolbar tests mentioned in the Issue Summary. |
|
What do you think about this MR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I have tried to run a PHPUnit test without success on a few modules (Admin toolbar, Simplenews), some tests pass, others fail. Adding DDEV Selenium Standalone Chrome helped resolve some tests, but I still got some Behat errors.
There are a lot of moving parts, and it would be nice to give new users a success from the start, where all tests are passing. We could add an example of a contrib module which fulfills this requirement, such as Config Enforce Devel.
Also, it would be nice with a human readable header.
How This PR Solves The Issue
Add a header, update the test commands, add links, add example of a successful test.