allow local phpunit config #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler36
force-pushed
the
20240216_phpunit_config
branch
from
8b6e2e6 to
4a94641
Compare
Merged
|
Failing because of "bad" tests. Check after #33 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves PHPunit configure-ablity.
The idea being, if a repository has phpunit config file present, it will default to using it.
Behavior
When running
ddev phpiunitIf a
phpunit.xml(PHPunit config file) is present, it used it by default.If a
phpunit.xmlis NOT present, it runs the command as currently set.Reasons
This PR allows developers to add and commit phpunit configuration which then can be used by default. These values could be added via CLI, but this become quite verbose if lots of settings are require (I was working on a module in a Gitpod workspace).
While devlopers can take control of the command and make the required adjust, doing so prevents future updates.