Less smart Drupal core version detection

[weitzman]

Issue discussion at #38

This is my proposal for version detection. Default to 10 (until 11 is released), and ask user to override via ddev config as needed. No more looking at DDEV_PROJECT_TYPE.

I'm unsure how best to override the env variable that this project's config.contrib.yaml. Supplies. Can user do that in their project's config.yaml, or do they need to create a config.zz.yaml?

[rfay]

I'm unsure how best to override the env variable that this project's config.contrib.yaml. Supplies. Can user do that in their project's config.yaml, or do they need to create a config.zz.yaml?

Either

• ddev config --web-environment-add=<SOMEENV>=<someval> is one way (same as editing web_environment in config.yaml or
• web_environment in a config.*.yaml

both seem fine to me.

[kekkis]

The _TARGET_CORE environment variable is not used anywhere though. The current environment variable name is DRUPAL_CORE. See https://git.drupalcode.org/project/gitlab_templates/-/raw/default-ref/scripts/expand_composer_json.php for reference; that is the script downloaded by the expand-composer-json command (the very script changed in this PR).

Snippet from said script at its current version:

$core_version = str_replace(['^', '~'], ['', ''], getenv('DRUPAL_CORE'));

[weitzman]

Woops, so this detection never worked right. Gosh, I wish people would report bugs more often.

I'll change the var name now.

[weitzman]

Fixed in #47