Add 'drupal' ProjectType in expand-composer-json #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'drupal' ProjectType was introduced in ddev v1.23.0 and will eventually replace drupal8, drupal9, and drupal10 ProjectTypes.
|
I think the line can be removed now. This script doesnt accept a projectType arg anymore. |
https://ddev.readthedocs.io/en/stable/users/extend/custom-commands/#projecttypes-annotation would indicate that it might be useful if we want to limit it to just drupal project types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The 'drupal' ProjectType was introduced in ddev v1.23.0 and will eventually replace drupal8, drupal9, and drupal10 ProjectTypes.
How This PR Solves The Issue
This PR adds the 'drupal' ProjectType in the annotation.
Related Issue Link(s)
#45 is where the change was originally made but was overlooked when closing the PR.