Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProjectTypes from commands #57

Merged
merged 1 commit into from
May 29, 2024
Merged

Remove ProjectTypes from commands #57

merged 1 commit into from
May 29, 2024

Conversation

weitzman
Copy link
Collaborator

The Issue

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

rfay
rfay approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. These are project-level custom commands. The purpose of ProjectTypes is to keep commands from showing in the help on non-project-type projects... but if you're installing this add-on you must want them!

@weitzman weitzman merged commit 903026a into main May 29, 2024
2 checks passed
@weitzman weitzman deleted the no-projectTypes branch May 29, 2024 03:23
@rfay rfay mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weitzman @rfay