Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install.yaml needs to list commands separately to avoid removal of commands directory #60

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 6, 2024

The Issue

The current install.yaml uses commands in the project_files section.

Unfortunately, that means that when the add-on is uninstalled, it will remove everything in the commands directory.

Using directories in project_files is OK if they're directories created/maintained by the add-on, but in this case, the directory is one that is shared more generally.

How This PR Solves The Issue

List the items in commands/web individually.

Manual Testing Instructions

  • Install the add-on and then remove it. It should not remove existing commands/web contents

You can install with ddev get https://github.com/rfay/ddev-drupal-contrib/tarball/20240606_explicit_commands

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@weitzman weitzman merged commit 5afeeab into ddev:main Jun 6, 2024
2 checks passed
@rfay
Copy link
Member Author

rfay commented Jun 6, 2024

(this may be a DDEV bug, but I'm not sure I know how to fix it.)

@rfay rfay deleted the 20240606_explicit_commands branch June 6, 2024 20:49
@rfay
Copy link
Member Author

rfay commented Jun 6, 2024

It will need a new release too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants