fix: install.yaml needs to list commands separately to avoid removal of commands
directory
#60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The current install.yaml uses
commands
in the project_files section.Unfortunately, that means that when the add-on is uninstalled, it will remove everything in the
commands
directory.Using directories in
project_files
is OK if they're directories created/maintained by the add-on, but in this case, the directory is one that is shared more generally.How This PR Solves The Issue
List the items in commands/web individually.
Manual Testing Instructions
You can install with
ddev get https://github.com/rfay/ddev-drupal-contrib/tarball/20240606_explicit_commands
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes