chore: make web commands executable #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I certainly think that it's best for commands to be executable in git, but the web-based view doesn't make it obvious that you're just changing perms. |
|
I see the change from 644 to 755:
|
|
I see the change, but on empty file. I couldn't understand why it was an empty file. |
|
Files are definitely not empty.. agree it's confusing https://github.com/hanoii/ddev-drupal-contrib/tree/commands-executable/commands/web |
|
I think I'm used to it, because I've seen similar behavior when changing file permissions locally in GitKraken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command files are made executable by default by ddev.
Just make sure all are executable so that upgrading the add on doesn't change the execute flag on the commands addon if we are tracking the addon on the project repo.