clarify how to enable VNC #18
Conversation
There was a problem hiding this comment.
I don't see anything wrong with this change, but could you explain why you would use this instead of browser on https://[DDEV SITE URL]:7900? If there is significant value, please also add to the README explaining this approach. Note that when you start using ports only one project at a time can be running with port 5900.
|
@rfay Ok, I updated the README with some basic guidelines that I hope are pretty easy to follow and non-controversial. |
|
Are there any additional steps needed? I can visit
|
|
@tyler36 There shouldn't be any additional setup required. Make sure you aren't running your tests headless. The tests that are shown are those that actually require the Chromium browser to be opened to run the tests, so if the tests are running headless in the background, they won't be shown. |
|
@ptmkenny Thanks for the suggestion. By removing |
|
|
||
| On your host, browse to https://[DDEV SITE URL]:7900 (password: `secret`) to watch tests run with noVNC (neat!). | ||
|
|
||
| This is a no-configuration solution that enables you to quickly see what is going on with your tests. |
There was a problem hiding this comment.
Considering we need to make configuration changes and restart DDEV, I'm not so sure about the wording here. 🤷
There was a problem hiding this comment.
Yeah, I didn't realize that --headless is set in the YAML file, so there should probably be a section on how and why to disable headless as well. What's the reason for setting --headless as a default in the first place? Is it just speed?
There was a problem hiding this comment.
I imaging there would be memory savings from using --headless, which might be more important when running on CI.
Note there are 2 references, one for Mink tests and one forr DTT tests.
@weitzman , are there issues removing this as the default?
There was a problem hiding this comment.
I'm able to watch just fine with the existing configuration.
|
Ping @weitzman before this gets too stale. |
This may be a rookie mistake, but I had trouble enabling VNC because I uncommented the "5900:5900" line and missed uncommenting "ports:". Another reason I missed this is that the indentation is wrong; "ports:" has to be at the level of "external_links". So I edited the comment to make it more clear about how to enable port 5900.