forked from kubernetes/community
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Created tombstone file for /devel/collab.md - updated URL in other files
- Loading branch information
Showing
5 changed files
with
40 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,3 @@ | ||
# On Collaborative Development | ||
This document has moved to: [here](https://git.k8s.io/community/contributors/guide/collab.md). | ||
|
||
## Code reviews | ||
|
||
All changes must be code reviewed. For non-maintainers this is obvious, since | ||
you can't commit anyway. But even for maintainers, we want all changes to get at | ||
least one review, preferably (for non-trivial changes obligatorily) from someone | ||
who knows the areas the change touches. For non-trivial changes we may want two | ||
reviewers. The primary reviewer will make this decision and nominate a second | ||
reviewer, if needed. Except for trivial changes, PRs should not be committed | ||
until relevant parties (e.g. owners of the subsystem affected by the PR) have | ||
had a reasonable chance to look at PR in their local business hours. | ||
|
||
Most PRs will find reviewers organically. If a maintainer intends to be the | ||
primary reviewer of a PR they should set themselves as the assignee on GitHub | ||
and say so in a reply to the PR. Only the primary reviewer of a change should | ||
actually do the merge, except in rare cases (e.g. they are unavailable in a | ||
reasonable timeframe). | ||
|
||
If a PR has gone 2 work days without an owner emerging, please poke the PR | ||
thread and ask for a reviewer to be assigned. | ||
|
||
Except for rare cases, such as trivial changes (e.g. typos, comments) or | ||
emergencies (e.g. broken builds), maintainers should not merge their own | ||
changes. | ||
|
||
Expect reviewers to request that you avoid [common go style | ||
mistakes](https://github.com/golang/go/wiki/CodeReviewComments) in your PRs. | ||
|
||
## Assigned reviews | ||
|
||
Maintainers can assign reviews to other maintainers, when appropriate. The | ||
assignee becomes the shepherd for that PR and is responsible for merging the PR | ||
once they are satisfied with it or else closing it. The assignee might request | ||
reviews from non-maintainers. | ||
*This file is a redirect stub. It should be deleted within 3 months from the current date.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# On Collaborative Development | ||
|
||
## Code reviews | ||
|
||
All changes must be code reviewed. For non-maintainers this is obvious, since | ||
you can't commit anyway. But even for maintainers, we want all changes to get at | ||
least one review, preferably (for non-trivial changes obligatorily) from someone | ||
who knows the areas the change touches. For non-trivial changes we may want two | ||
reviewers. The primary reviewer will make this decision and nominate a second | ||
reviewer, if needed. Except for trivial changes, PRs should not be committed | ||
until relevant parties (e.g. owners of the subsystem affected by the PR) have | ||
had a reasonable chance to look at PR in their local business hours. | ||
|
||
Most PRs will find reviewers organically. If a maintainer intends to be the | ||
primary reviewer of a PR they should set themselves as the assignee on GitHub | ||
and say so in a reply to the PR. Only the primary reviewer of a change should | ||
actually do the merge, except in rare cases (e.g. they are unavailable in a | ||
reasonable timeframe). | ||
|
||
If a PR has gone 2 work days without an owner emerging, please poke the PR | ||
thread and ask for a reviewer to be assigned. | ||
|
||
Except for rare cases, such as trivial changes (e.g. typos, comments) or | ||
emergencies (e.g. broken builds), maintainers should not merge their own | ||
changes. | ||
|
||
Expect reviewers to request that you avoid [common go style | ||
mistakes](https://github.com/golang/go/wiki/CodeReviewComments) in your PRs. | ||
|
||
## Assigned reviews | ||
|
||
Maintainers can assign reviews to other maintainers, when appropriate. The | ||
assignee becomes the shepherd for that PR and is responsible for merging the PR | ||
once they are satisfied with it or else closing it. The assignee might request | ||
reviews from non-maintainers. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters