-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #5
Conversation
This still works for me. Wasn't sure what version bump you'd like for the package... but i've gone for major to match `resemblejs`
thanks, i gonna test it on weekend |
@ddo did you get time to review the PR at the weekend? |
any luck? I've been using this updated code for apps and have it as part of our CI, so it works for me if that helps... |
Hi, Have you any interest in merging this PR? If not i'll publish my update (with thanks to you for the original code) |
@ddo Please accept this PR. I need it as well. |
@peter-mouland Could you publish your fixes in worst case and link the NPM module? |
hey @ddo, This PR is still open - shall i just close it and hope people find my v2 repo instead? |
i gonna test and decide later, ty |
FYI, I've been using the updated (v2) since October daily with automated regression testing so I can at least verify for my use case it is solid. |
ty https://github.com/ddo/node-resemble/releases/tag/2.0.0 there are still minor issues:
|
I've had to set the overrides on
global
as Resemble now seems to use theImage
andFileReader
that comes with the browser.Wasn't sure what version bump you'd like for the package... but i've gone for major to match
resemblejs
.fixes #2