Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #5

Merged
merged 4 commits into from
Mar 23, 2017
Merged

update dependencies #5

merged 4 commits into from
Mar 23, 2017

Conversation

peter-mouland
Copy link
Contributor

@peter-mouland peter-mouland commented Oct 3, 2016

I've had to set the overrides on global as Resemble now seems to use the Image and FileReader that comes with the browser.

Wasn't sure what version bump you'd like for the package... but i've gone for major to match resemblejs.

fixes #2

This still works for me.

Wasn't sure what version bump you'd like for the package... but i've gone for major to match `resemblejs`
@ddo
Copy link
Owner

ddo commented Oct 6, 2016

thanks, i gonna test it on weekend

@peter-mouland
Copy link
Contributor Author

@ddo did you get time to review the PR at the weekend?

@peter-mouland
Copy link
Contributor Author

any luck?

I've been using this updated code for apps and have it as part of our CI, so it works for me if that helps...

@peter-mouland
Copy link
Contributor Author

Hi,

Have you any interest in merging this PR?

If not i'll publish my update (with thanks to you for the original code)

@JonWallsten
Copy link

@ddo Please accept this PR. I need it as well.

@JonWallsten
Copy link

@peter-mouland Could you publish your fixes in worst case and link the NPM module?

@peter-mouland
Copy link
Contributor Author

@JonWallsten just released on npm https://github.com/peter-mouland/node-resemble-v2 / https://www.npmjs.com/package/node-resemble-v2

@peter-mouland
Copy link
Contributor Author

hey @ddo, This PR is still open - shall i just close it and hope people find my v2 repo instead?

@ddo
Copy link
Owner

ddo commented Mar 22, 2017

i gonna test and decide later, ty

@peter-mouland
Copy link
Contributor Author

FYI, I've been using the updated (v2) since October daily with automated regression testing so I can at least verify for my use case it is solid.

@ddo ddo merged commit 7cbf211 into ddo:master Mar 23, 2017
@peter-mouland peter-mouland deleted the patch-1 branch March 23, 2017 09:09
@ddo
Copy link
Owner

ddo commented Mar 23, 2017

ty https://github.com/ddo/node-resemble/releases/tag/2.0.0

there are still minor issues:

  • image-type v3
  • onError if the resemble supports it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update resemble 2.0
3 participants