Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC is being used for 2 currencies #32

Closed
harroyoc opened this issue Nov 20, 2017 · 3 comments
Closed

CRC is being used for 2 currencies #32

harroyoc opened this issue Nov 20, 2017 · 3 comments
Labels

Comments

@harroyoc
Copy link

Costa Rican Colon (CRC) exchange rate is either completely off, or the workflow is using the CraftCoin (also CRC) currency when converting to CRC.

crc

@deanishe
Copy link
Owner

the workflow is using the CraftCoin (also CRC) currency when converting to CRC

That's exactly what's happening.

It looks like quite a few cryptocurrencies duplicate the symbols of fiat currencies.

For the time being, I've disabled conflicting currencies (mostly the crypto ones).

Grab v3.3.1 from releases or enter conv workflow:update into Alfred.

Enter conv workflow:delcache if you'd like to force exchange rates to be updated immediately (the bad data will still be in the cache).

@deanishe deanishe added the bug label Nov 21, 2017
@rwitchell
Copy link

is it possible that you modify the plugin to output multiple results, one for each currency?

@deanishe
Copy link
Owner

is it possible that you modify the plugin to output multiple results, one for each currency?

No, I'm afraid not. The pint library (perfectly understandably) expects a name to refer to a single unit only.

It might be possible if the conflicting units weren't both currencies, but if the creators of CraftCoin (and the rest) were silly enough to use a code that's already assigned to a different currency, then it was bound to cause some issues…

If you'd rather have CraftCoin than the Costa Rican colon, you can uncomment the former and comment out the latter in config.py.

The only currencies that are fundamentally unsupported are ones whose currency codes begin with digits.

I'm closing this issue, as I've solved the issue, albeit by removing some currencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants