Skip to content

Commit

Permalink
fix pkg-config metadata for shared abseil on windows (protocolbuffers…
Browse files Browse the repository at this point in the history
…#15888)

Closes protocolbuffers#15883, tested in conda-forge/libprotobuf-feedstock#209

Closes protocolbuffers#15888

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15888 from h-vetinari:absl_pkgconfig 9062aa9
PiperOrigin-RevId: 609206067
  • Loading branch information
h-vetinari authored and deannagarcia committed Jun 20, 2024
1 parent bf6cfd3 commit 6f3e973
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cmake/install.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
include(GNUInstallDirs)

foreach(_target IN LISTS protobuf_ABSL_USED_TARGETS)
string(REPLACE :: _ _modified_target ${_target})
# shared abseil on windows breaks the absl::foo -> absl_foo replacement logic -
# preempt this by a more specific replace (harmless if it doesn't apply); see GH-15883
string(REPLACE "absl::abseil_dll" "abseil_dll" _modified_target ${_target})
string(REPLACE :: _ _modified_target ${_modified_target})
list(APPEND _pc_targets ${_modified_target})
endforeach()
list(APPEND _pc_targets "utf8_range")
Expand Down

0 comments on commit 6f3e973

Please sign in to comment.