Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Implementation Update #3

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

deanstef
Copy link
Owner

This update to the reference implementation introduces the following changes:

  • Authentication message: introduced chainId parameter that specifies the Algorand network in which the authentication account operates;
  • Authentication request: the client specifies the chainId for the authentication account
  • Simplified authentication message encoding
    • removed unused prefix arc31:j
    • added arc0031 prefix compliant with Algorand domain sepration
    • removed msgpack in favour of pure JSON (rational: auth message is not a large object and does not require particular msgpacking)
  • Added chainId entry to user mock DB: the Verifier must keep track of the chainId to use for signature validation

@deanstef deanstef requested a review from mrcointreau February 18, 2024 16:20
assets/arc-0031/client/utils/hooks/useAuth.ts Show resolved Hide resolved
assets/arc-0031/client/utils/hooks/useAuth.ts Outdated Show resolved Hide resolved
assets/arc-0031/client/utils/hooks/useAuth.ts Outdated Show resolved Hide resolved
assets/arc-0031/server/routes/api/v1.ts Show resolved Hide resolved
@mrcointreau mrcointreau self-requested a review February 20, 2024 08:47
@deanstef deanstef merged commit 8e81a9e into minor-review/arc31 Feb 20, 2024
3 of 5 checks passed
@deanstef deanstef deleted the update/arc31-ref branch February 20, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants