Header donation #91
Merged
Header donation #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on mobile we will render the donate slot within the menu whereas desktop will live within the header, besides, desktop on logged user will still have a donate button
also this commit will format collapser file
ideally we should be able to use a slot with the same name that take place twice on the structure
orlando
reviewed
Nov 19, 2020
| <dc-user-items user={this.user} community={this.community} /> | ||
| <div class="with-user"> | ||
| <slot name="donate"> | ||
| {this.donateurl && ( |
There was a problem hiding this comment.
Can we remove this now the fix has landed on Stencil?
There was a problem hiding this comment.
It has been merge to master on the stenciljs project but it hasn't get released yet @orlando
https://github.com/ionic-team/stencil/commits/master currently the latest version is 2.3.0 and it doesn't have the fix yet.
There was a problem hiding this comment.
I have created a technical debt for this one so we can move forward now
arathjz
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add support to inject custom donation component
Why:
relates to the effort of
Gatsby link for Donate button
How:
Use the
slotAPI from stencil to allow render a custom component whenever thedonateurlis set to falsy valueThe need of use a donateurl to false comes from the bug that has been addressed with ionic-team/stencil#2650
Extras:
This code will add donate button on mobile and desktop for users and guests, besides some other aesthetics details.
Media: