refactor: marketplace #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachomazzara
requested changes
Oct 8, 2018
| debounce={index * 100} | ||
| /> | ||
| ))} | ||
| {assets.map( |
There was a problem hiding this comment.
We could use AssetCard here
| @@ -23,15 +22,15 @@ export function marketplaceReducer(state = INITIAL_STATE, action) { | |||
| [assetType]: total | |||
| } | |||
| } | |||
| let newGrid = action.isGrid | |||
There was a problem hiding this comment.
Is it ok if we change it to const ?
|
looks good! |
cazala
pushed a commit
that referenced
this pull request
Oct 8, 2018
* feat: simplify actions, use /marketplace for pubs and inactive tab at marketplace * refactor: marketplace (#528) * refactor: marketplace * chore: applied changes after review * fix: render badge ar markaetplace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
tabinto a query paramasset_type.This keeps it consistent with the server API, and it lets us use the logic already implemented in the
Locationclass to build paths and extract values from the router.Also it allow us to have a single route for the marketplace (no need for
marketplaceDefaultPagelocation)This PR also refactores the MarketplacePage to work with
assetsinstead ofparcelsandestates, which reduces repeated logic.This PR also fixes a race condition that happened when the MarketplacePage was mounted and the publications for each asset type were fetched: now it relies on the router instead of the order that the actions are dispatched.