Fix shopify loader (#73)

Signed-off-by: Marcos Candeia <[email protected]>
deco-sites · May 17, 2023 · 667ef16 · 667ef16
1 parent 4996498
commit 667ef16
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/commerce/shopify/transform.ts b/commerce/shopify/transform.ts
@@ -39,6 +39,7 @@ const nonEmptyArray = <T>(array: T[] | null | undefined) =>
 
 export const toProductPage = (
   product: ProductShopify,
+  url: URL,
   maybeSkuId?: number,
 ): ProductDetailsPage => {
   const skuId = maybeSkuId
@@ -53,7 +54,7 @@ export const toProductPage = (
   return {
     "@type": "ProductDetailsPage",
     breadcrumbList: toBreadcrumbList(product, sku),
-    product: toProduct(product, sku),
+    product: toProduct(product, sku, url),
   };
 };
 
@@ -76,6 +77,7 @@ export const toBreadcrumbList = (
 export const toProduct = (
   product: ProductShopify,
   sku: SkuShopify,
+  url: URL,
   level = 0, // prevent inifinte loop while self referencing the product
 ): Product => {
   const {
@@ -100,7 +102,7 @@ export const toProduct = (
   const additionalProperty = selectedOptions.map(toPropertyValue);
   const allImages = nonEmptyArray([image, ...images.nodes]) ?? [DEFAULT_IMAGE];
   const hasVariant = level < 1 &&
-    variants.nodes.map((variant) => toProduct(product, variant, 1));
+    variants.nodes.map((variant) => toProduct(product, variant, url, 1));
   const priceSpec: UnitPriceSpecification[] = [{
     "@type": "UnitPriceSpecification",
     priceType: "https://schema.org/SalePrice",
@@ -118,7 +120,7 @@ export const toProduct = (
   return {
     "@type": "Product",
     productID,
-    url: getPath(product, sku),
+    url: `${url.host}${getPath(product, sku)}`,
     name: sku.title,
     description,
     sku: productID,
@@ -130,7 +132,7 @@ export const toProduct = (
       "@type": "ProductGroup",
       productGroupID,
       hasVariant: hasVariant || [],
-      url: getPath(product),
+      url: `${url.host}${getPath(product)}`,
       name: product.title,
       additionalProperty: [],
     },

diff --git a/functions/shopifyProductDetailsPage.ts b/functions/shopifyProductDetailsPage.ts
@@ -36,7 +36,7 @@ const productPageLoader: LoaderFunction<
     };
   }
 
-  const product = toProductPage(data.product, maybeSkuId);
+  const product = toProductPage(data.product, new URL(_req.url), maybeSkuId);
 
   return { data: product };
 };

diff --git a/functions/shopifyProductList.ts b/functions/shopifyProductList.ts
@@ -41,7 +41,7 @@ const searchLoader: LoaderFunction<
   // If a property is missing from the final `products` array you can add
   // it in here
   const products = data?.products.nodes.map((p) =>
-    toProduct(p, p.variants.nodes[0])
+    toProduct(p, p.variants.nodes[0], new URL(_req.url))
   );
 
   return {
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,7 +36,7 @@ const productPageLoader: LoaderFunction< @@
         };
       }
-      const product = toProductPage(data.product, maybeSkuId);
+      const product = toProductPage(data.product, new URL(_req.url), maybeSkuId);
       return { data: product };
     };
@@ Expand Down @@