Theme | Add Fallback in Theme #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stherzada
changed the title
matheusgr
requested changes
Nov 14, 2024
| @@ -198,6 +198,29 @@ const toVariables = ( | |||
| "--inc": t["info-content"] ?? contrasted(t["info"]), | |||
| }).map(([key, color]) => [key, toValue(color)] as [string, string]); | |||
|
|
|||
| const fallbackVariables = Object.entries({ | |||
| "--fallback-p": t["primary"], | |||
There was a problem hiding this comment.
Daisy UI theme uses the fallback variables as follow:
"primary": "var(--fallback-p,oklch(var(--p)/<alpha-value>))",
So, if fallback-* is used, the other variables are ignored.
Those variables should be set ONLY if oklch is not supported by browser.
See https://github.com/saadeghi/daisyui/blob/master/src/base/colors.css to a better approach:
@supports not (color: oklch(0% 0 0)) {
:root {
color-scheme: light;
--fallback-p: #491eff;
--fallback-pc: #d4dbff;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi people,
I noticed an issue where older versions of Safari weren't displaying theme colors correctly due to the lack of support for OKLCH. To resolve this, I created a fallback to ensure compatibility.
This fallback will be included at the start of every new project to prevent similar issues.
Here's a demonstration:
Without fallback:
https://www.loom.com/share/7c6acd9c3c4549f09316bcea84fa9c92
With fallback:
https://www.loom.com/share/9cad4d0804b443a28f464bb00cf0dfe3