Use AllowHighFees in SendRawTransaction cmd to actually check tx fees #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
force-pushed
the
ayp_allowhighfees
branch
from
ef71a45 to
924eb80
Compare
|
This seems good in my testing (when used with decred/dcrwallet#194 |
alexlyp
force-pushed
the
ayp_allowhighfees
branch
from
924eb80 to
33b63be
Compare
AllowHighFee (default to false) in sendrawtransaction will protect the user from accidentally sending out fees with unreasonably high fee/kb tx. We have decided that 100x times min relay fee/kb is a sensible upper limit for this check. But if people choice to force through tx they can always set this flag to true and the check will be removed.
alexlyp
force-pushed
the
ayp_allowhighfees
branch
from
89764e1 to
b7e88f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tx fee/kb are 100x above the minimum (1e6 atoms) and AllowHighFees is false (default), then error and don't allow the tx to be broadcast.
This will not effect any other incoming tx to this node, it is only being checked for sendrawtransaction coming out of that node.
Fixes issue 187 in dcrwallet