Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool: Synchronize btcd commits fixing orphan hang #155

Merged
merged 2 commits into from
May 5, 2016

Conversation

cjepson
Copy link
Contributor

@cjepson cjepson commented May 5, 2016

The mempool would hang when processing orphans occasionally because
some orphans would be added continuously to the orphan pool. This was
fixed in btcd previously by changing a list to a map.

@cjepson cjepson changed the title mempool: Have ProcessTransaction return accepted transactions. (#547) mempool: Synchronize btcd commits fixing orphan hang May 5, 2016
@cjepson cjepson force-pushed the cj_050516syncmp branch from ab4fcc5 to b43e495 Compare May 5, 2016 18:36
@alexlyp
Copy link
Member

alexlyp commented May 5, 2016

tACK on testnet

1 similar comment
@jolan
Copy link
Contributor

jolan commented May 5, 2016

tACK on testnet

@jcvernaleo
Copy link
Member

Running fine on testnet for me as well.

dajohi added 2 commits May 5, 2016 16:17
…ite#547)

It is not the responsibility of mempool to relay transactions, so
return a slice of transactions accepted to the mempool due to the
passed transaction to the caller.
This is more efficient and prevents duplicate entries which can
lead to no-longer-orphans being attempted be added to the mempool
multiple times.

Bug found by me, debugged with @davecgh, and patch from @davecgh
@cjepson cjepson force-pushed the cj_050516syncmp branch from b43e495 to 0b6f881 Compare May 5, 2016 20:18
@alexlyp alexlyp merged commit 0b6f881 into decred:master May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants