mempool/peer: Sync upstream comment updates. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProcessTransaction could have accepted a new transaction into mempool but could have returned a reject message if a no-longer-orphan transaction failed to be accepted. This would also skip any additional no-longer-orphans, keeping them in the orphan pool. Instead of returning an error incorrectly, log the error and skip the no-longer-orphan transaction. This allows the rest of the no-longer-orphans to be processed as well.
|
OK |
1 similar comment
|
OK |
davecgh
force-pushed
the
merge_upstream_misc
branch
from
56214ff to
4bffbb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commits
The changes in d765c73 had previously been cherry-picked, so it's effectively a NOOP.