pool: Improve payment UUID with random value. #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
Sep 25, 2023
The UUID used for the payment ID was not created with any randomness to it, leading to occasional test failures due to duplicated values. Appending a random value to the UUID helps to ensure uniqueness. The commit also updates the database upgrade code to ensure the old payment ID format is used when performing the old version upgrade.
|
Rebased this on #391 which means all of the changes to |
davecgh
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UUID used for the payment ID was not created with any randomness to it, leading to occasional test failures due to duplicated values. Appending a random value to the UUID helps to ensure uniqueness.
The commit also updates the database upgrade code to ensure the old payment ID format is used when performing the old version upgrade.