Help prevent errors during initial sync by waiting for it to finish #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wallet would sometimes drop or mishandle notifications that came in synchronously when wallet was doing a resync. This ensures the resync has been completely before launching notification handling.
cjepson
force-pushed
the
cj_290316synchotfix2
branch
from
8eb5201 to
6bf720c
Compare
|
Looks good and works in my testing. |
|
seems to work OK, |
beansgum
pushed a commit
to beansgum/dcrwallet
that referenced
this pull request
Jun 10, 2021
* make pass modal fill entire window * fix selected wallet mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet would sometimes drop or mishandle notifications that came in
synchronously when wallet was doing a resync. This ensures the resync
has been completely before launching notification handling.