Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ client: Fix docs build by locking sphinx to version 7.1.2 for now #4335

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Aug 18, 2023

For the time being we lock the Sphinx version to 7.1.2

This works around the bug described in
sphinx-doc/sphinx#11605

Sphinx made a breaking change, but believes that the Breathe project is incorrectly relying on the wrong behavior, so at this point it's up to Breathe to fix.

Until then we sync to an older version of Sphinx.

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 18, 2023
@kosak kosak enabled auto-merge (squash) August 18, 2023 13:59
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think we probably should do this for all the wheels, but for the moment let's just do the one that fixes it.

@kosak kosak merged commit cd23fef into deephaven:main Aug 18, 2023
11 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
@kosak kosak deleted the kosak_fix-sphinx-docs-build branch August 18, 2023 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants