-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support generic publish/fetch for plugins #5990
feat: Support generic publish/fetch for plugins #5990
Conversation
aa28a53
to
a6b5198
Compare
4e563ac
to
d6668cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My chief concerns here are that it might go too far in that it may break downstream code that uses some of these existing apis. If we're not bothered by that... perhaps it doesn't go far enough, and we should limit what kinds of tickets can be passed into what APIs, or what kinds of tickets are even possible to see in some cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be sure to test end-to-end with Jupyter.
Co-authored-by: Chip Kent <[email protected]>
Co-authored-by: Chip Kent <[email protected]> Co-authored-by: Ryan Caudy <[email protected]>
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#312 |
Closes #5944