Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support generic publish/fetch for plugins #5990

Merged

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Aug 26, 2024

Closes #5944

@jmao-denver jmao-denver added this to the 0.37.0 milestone Aug 26, 2024
@jmao-denver jmao-denver self-assigned this Aug 26, 2024
@jmao-denver jmao-denver force-pushed the 5944-pyclient-share-any-export branch from aa28a53 to a6b5198 Compare August 27, 2024 20:24
@jmao-denver jmao-denver changed the title feat: Expose Ticket types for lower level publish/fetch methods to share generic server objects feat: Support generic publish/fetch for plugins Aug 27, 2024
@jmao-denver jmao-denver marked this pull request as ready for review August 28, 2024 15:00
@jmao-denver jmao-denver force-pushed the 5944-pyclient-share-any-export branch from 4e563ac to d6668cc Compare September 4, 2024 19:59
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My chief concerns here are that it might go too far in that it may break downstream code that uses some of these existing apis. If we're not bothered by that... perhaps it doesn't go far enough, and we should limit what kinds of tickets can be passed into what APIs, or what kinds of tickets are even possible to see in some cases.

py/client/pydeephaven/_arrow_flight_service.py Outdated Show resolved Hide resolved
py/client/pydeephaven/_session_service.py Outdated Show resolved Hide resolved
py/client/pydeephaven/ticket.py Show resolved Hide resolved
py/client/pydeephaven/experimental/plugin_client.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/server_object.py Outdated Show resolved Hide resolved
py/client/pydeephaven/server_object.py Outdated Show resolved Hide resolved
py/client/pydeephaven/server_object.py Outdated Show resolved Hide resolved
py/client/pydeephaven/table.py Outdated Show resolved Hide resolved
py/client/pydeephaven/ticket.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Show resolved Hide resolved
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to test end-to-end with Jupyter.

py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/ticket.py Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/ticket.py Show resolved Hide resolved
@jmao-denver jmao-denver merged commit dcd7fc5 into deephaven:main Sep 23, 2024
16 checks passed
@jmao-denver jmao-denver deleted the 5944-pyclient-share-any-export branch September 23, 2024 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#312

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a general way to bind objects to pydeephaven sessions
5 participants