fix(py-client-test): Read PluginClients In Order; fix shared_ticket Ref #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
nbauernfeind
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
nbauernfeind
force-pushed
the
gh_5996_work_around
branch
from
06064bc to
45d0540
Compare
jmao-denver
reviewed
Sep 30, 2024
Co-authored-by: Jianfeng Mao <[email protected]>
niloc132
approved these changes
Sep 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to investigation in #5996. Colin thinks he has the true final work around for the issue that we were able to reproduce. In the meantime, we'll swap the order of the tests to reduce the probability of it occurring.
I also adjusted one of the tests to hit the already-expired shared_ticket error case (it was failing for a different reason as the ticket referenced was a live table and not the shared ticket anymore.)
The ObjectService change is to adopt the proper pattern for ExportObject requirements. In this case it does not matter since all of those
dependenciesare new server-side exports that the client has not yet been told about; they'll be guaranteed to live until they've been written to the stream. BUT, for the sake of consistency we should manage the requirements as soon as we can.