Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs with regression label standardization #456

Merged
merged 1 commit into from
Jul 14, 2020
Merged

fix bugs with regression label standardization #456

merged 1 commit into from
Jul 14, 2020

Conversation

rohanag
Copy link
Contributor

@rohanag rohanag commented Jul 10, 2020

fixes #452

@Timoeller Timoeller self-requested a review July 13, 2020 09:55
@Timoeller Timoeller self-assigned this Jul 13, 2020
Timoeller
Timoeller approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Tested the code on a small regression dataset.

Thanks for the improvements @rohanag

@Timoeller Timoeller merged commit b98884d into deepset-ai:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees

@Timoeller Timoeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression processor label standardization inconsistencies
2 participants
@rohanag @Timoeller